Skip to content

chore: fix JavaScript lint errors (issue #8169) #8176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2025
Merged

chore: fix JavaScript lint errors (issue #8169) #8176

merged 2 commits into from
Oct 1, 2025

Conversation

Payal-Goswami
Copy link
Contributor

@Payal-Goswami Payal-Goswami commented Oct 1, 2025 •
edited
Loading

Resolves #8169.

Description

This pull request fixes the linting issues reported in #8169:

  • Moved cb function to outer scope in utils/async/reduce-right/lib/limit.js to comply with stdlib/no-unnecessary-nested-functions.
  • Removed unused eslint-disable directive in assert/is-nonpositive-number/benchmark/benchmark.js

Related Issues

This pull request:

Questions

No.

Other

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Oct 1, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Oct 1, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
assert/is-nonpositive-number $\color{green}245/245$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}245/245$
$\color{green}+100.00\%$
utils/async/reduce-right $\color{green}559/559$
$\color{green}+100.00\%$ 		$\color{green}66/66$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}559/559$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
style: add empty line
c953d4c 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Oct 1, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 1, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Oct 1, 2025 •
edited by Planeshifter
Loading

PR Commit Message

chore: fix JavaScript lint errors

PR-URL: https://github.com/stdlib-js/stdlib/pull/8176
Closes: https://github.com/stdlib-js/stdlib/issues/8169

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 78351b3 into stdlib-js:develop Oct 1, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants

@Payal-Goswami @stdlib-bot @Planeshifter